Refactor Module to allow definition of types #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… way of configuring otelcol
ekohl
requested changes
Nov 22, 2023
ekohl
reviewed
Nov 22, 2023
There was a problem hiding this comment.
You can easily run the example files as an acceptance test: https://github.com/voxpupuli/voxpupuli-acceptance/#examples
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
ekohl
reviewed
Nov 23, 2023
Remove Template need Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
ekohl
reviewed
Nov 24, 2023
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Co-authored-by: Ewoud Kohl van Wijngaarden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new way of defining Types. This way it is more flexible to add Components to the configuration with puppetcode